Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e/framework: remove direct imports to /pkg/controller/nodelifecycle #89243

Merged
merged 1 commit into from
Mar 24, 2020
Merged

e2e/framework: remove direct imports to /pkg/controller/nodelifecycle #89243

merged 1 commit into from
Mar 24, 2020

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Mar 19, 2020 •
edited

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
e2e/framework: remove direct imports to /pkg/controller/nodelifecycle

Which issue(s) this PR fixes:

Ref #74352

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 19, 2020
@SataQiu
Copy link
Member Author

SataQiu commented Mar 19, 2020

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 19, 2020
@SataQiu
Copy link
Member Author

SataQiu commented Mar 19, 2020

/cc @neolit123 @oomichi

oomichi
oomichi reviewed Mar 19, 2020
View reviewed changes
Copy link
Member

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, just few comment.
Could you update them with rebasing this on the latest master?

test/e2e/framework/node/resource.go Outdated
@@ -47,6 +46,21 @@ const (
sshPort = "22"
)

var (
// UnreachableTaintTemplate is the taint for when a node becomes unreachable.
UnreachableTaintTemplate = &v1.Taint{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used within this file, so we can define this as a local with unreachableTaintTemplate.

test/e2e/framework/node/resource.go Outdated

// NotReadyTaintTemplate is the taint for when a node is not ready for
// executing pods
NotReadyTaintTemplate = &v1.Taint{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@SataQiu SataQiu force-pushed the staging-e2e-framework-20200319 branch from ec21d10 to cfa499f Compare March 20, 2020 02:32
@SataQiu
Copy link
Member Author

SataQiu commented Mar 20, 2020

/test pull-kubernetes-e2e-kind-ipv6

andrewsykim
andrewsykim reviewed Mar 20, 2020
View reviewed changes
test/e2e/framework/node/resource.go
@@ -46,6 +45,21 @@ const (
sshPort = "22"
)

var (
// unreachableTaintTemplate is the taint for when a node becomes unreachable.
unreachableTaintTemplate = &v1.Taint{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a comment referencing where this taint is originally from?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

@SataQiu SataQiu force-pushed the staging-e2e-framework-20200319 branch from cfa499f to 799cdbf Compare March 21, 2020 03:09
@SataQiu
Copy link
Member Author

SataQiu commented Mar 21, 2020

/test pull-kubernetes-e2e-kind

@SataQiu
Copy link
Member Author

SataQiu commented Mar 22, 2020

ping @andrewsykim
Could you review this again?

oomichi
oomichi reviewed Mar 23, 2020
View reviewed changes
Copy link
Member

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2020
@SataQiu
Copy link
Member Author

SataQiu commented Mar 24, 2020

/test pull-kubernetes-e2e-gce-100-performance

@k8s-ci-robot k8s-ci-robot merged commit cc06d2a into kubernetes:master Mar 24, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oomichi oomichi oomichi left review comments

@andrewsykim andrewsykim andrewsykim left review comments

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@neolit123 neolit123 Awaiting requested review from neolit123

Assignees

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SataQiu @k8s-ci-robot @oomichi @andrewsykim